Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some tests #1766

Merged
merged 29 commits into from Mar 21, 2022
Merged

Rename some tests #1766

merged 29 commits into from Mar 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2022

Proposed Changes

Preliminary renaming of tests of stores to test_store_* for consistency, preparatory to migration from unittest to pytest.

dependabot bot and others added 19 commits January 17, 2022 11:58
Bumps [black](https://github.com/psf/black) from 21.9b0 to 21.12b0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [black](https://github.com/psf/black) from 21.12b0 to 22.1.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits/22.1.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@ghost ghost requested review from white-gecko, aucampia and nicholascar March 17, 2022 18:15
aucampia
aucampia previously approved these changes Mar 17, 2022
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment in PR #1765: can we please have a parsers/ serializers/ and now stores/ folder in test/ and put all these files in there?

@ghost
Copy link
Author

ghost commented Mar 18, 2022

As per my comment in PR #1765: can we please have a parsers/ serializers/ and now stores/ folder in test/ and put all these files in there?

I've made a first cut at this, moving all the obviously-named files into subfolders. I haven't tackled the legacy format-specific test files (e.g. n3, trig) which test both parsing and serialization.

@aucampia
Copy link
Member

There are some other changes in here other than renaming, is that intentional? If so I will have to take a more careful look when I have time.

@aucampia aucampia dismissed their stale review March 19, 2022 09:53

Need to check new changes

@ghost
Copy link
Author

ghost commented Mar 19, 2022

There are some other changes in here other than renaming, is that intentional? If so I will have to take a more careful look when I have time.

Argh, nearly all of those were completely unintended, thanks for the catch. I've reverted all the unintended changes, leaving just the relatively few changes necessary to fulfil nicholascar's request to migrate parser/serializer/store tests into separate folders.

@nicholascar nicholascar self-requested a review March 20, 2022 12:11
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now after the recent tidy-ups!

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for making the test more organized @gjhiggins

@ghost
Copy link
Author

ghost commented Mar 21, 2022

If there are no further comments, shall I merge this to master?

@aucampia
Copy link
Member

If there are no further comments, shall I merge this to master?

Yes, I will merge later tonight if you have not yet.

@ghost
Copy link
Author

ghost commented Mar 21, 2022

If there are no further comments, shall I merge this to master?

Yes, I will merge later tonight if you have not yet.

Thank you, merging one's own PRs isn't a good look 😄

@aucampia aucampia merged commit 03c5e79 into RDFLib:master Mar 21, 2022
@ghost ghost deleted the rename-some-tests branch March 21, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants