New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some tests #1766
Rename some tests #1766
Conversation
Bumps [black](https://github.com/psf/black) from 21.9b0 to 21.12b0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bump black from 21.9b0 to 21.12b0
Bumps [black](https://github.com/psf/black) from 21.12b0 to 22.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits/22.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bump black from 21.12b0 to 22.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my comment in PR #1765: can we please have a parsers/ serializers/ and now stores/ folder in test/ and put all these files in there?
I've made a first cut at this, moving all the obviously-named files into subfolders. I haven't tackled the legacy format-specific test files (e.g. n3, trig) which test both parsing and serialization. |
There are some other changes in here other than renaming, is that intentional? If so I will have to take a more careful look when I have time. |
Argh, nearly all of those were completely unintended, thanks for the catch. I've reverted all the unintended changes, leaving just the relatively few changes necessary to fulfil nicholascar's request to migrate parser/serializer/store tests into separate folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now after the recent tidy-ups!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for making the test more organized @gjhiggins
If there are no further comments, shall I merge this to master? |
Yes, I will merge later tonight if you have not yet. |
Thank you, merging one's own PRs isn't a good look 😄 |
Proposed Changes
Preliminary renaming of tests of stores to test_store_* for consistency, preparatory to migration from unittest to pytest.