Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert namespace tests to pytest #1782

Merged

Conversation

aucampia
Copy link
Member

Summary of changes

This change refactors the unittest based tests for namespaces to
pytest based tests. This is primarily in preparation for adding a
new tests.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia added good first issue Good for newcomers review wanted This indicates that the PR is ready for review labels Mar 31, 2022
@aucampia aucampia removed the good first issue Good for newcomers label Apr 4, 2022
@ghost
Copy link

ghost commented Apr 5, 2022

My bad, I hadn't spotted this PR and I should have. In merged PR #1788 test/test_namespace.py has been moved to test/test_namespace/test_namespace.py

Have I been a bit heavy-handed in my approach to the migration of unittests to pytest? I've been refactoring out all of the unittest stuff. Is retaining the unittest class structure a more elegant approach?

@nicholascar
Copy link
Member

Have I been a bit heavy-handed in my approach to the migration of unittests to pytest? I've been refactoring out all of the unittest stuff. Is retaining the unittest class structure a more elegant approach?

Nah, kill all that awful Unittest non-Pythonic code! I admire your diligence in making the change! If I had done the test restructuring, I likely would not have done the refactoring too, but it's better off done.

This change refactors the `unittest` based tests for namespaces to
pytest based tests. This is primarily in preparation for adding a
new tests.
@aucampia aucampia force-pushed the iwana-20220330T2322-test_ns_invalid_uri branch from db0109c to a0adf68 Compare April 5, 2022 18:01
@aucampia
Copy link
Member Author

aucampia commented Apr 5, 2022

My bad, I hadn't spotted this PR and I should have. In merged PR #1788 test/test_namespace.py has been moved to test/test_namespace/test_namespace.py

@gjhiggins it is fine 😄 I tagged you for review, not because you were moving it, quick enough to rebase.

@aucampia aucampia merged commit 0776ea3 into RDFLib:master Apr 5, 2022
@aucampia aucampia deleted the iwana-20220330T2322-test_ns_invalid_uri branch April 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants