Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for computing qname on invalid URIs #1783

Merged
merged 1 commit into from Apr 12, 2022
Merged

Add tests for computing qname on invalid URIs #1783

merged 1 commit into from Apr 12, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Mar 30, 2022 •
edited

Summary of changes

This change adds a test for functionality that is currently not being
tested.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia changed the title iwana 20220330T2346 test ns invalid uri Add tests for computing qname on invalid URIs Mar 30, 2022
@aucampia
Copy link
Member Author

Will publish after:

@aucampia
Copy link
Member Author

aucampia commented Apr 5, 2022 •
edited

@gjhiggins please redo this then on master. This was anyway to test something you worked on.

EDIT: Sorry, I think I misunderstood your comment on #1782 - I will fix it after rebasing that, I see it was just moved.

@aucampia aucampia force-pushed the iwana-20220330T2346-test_ns_invalid_uri branch from 6f87944 to 42ccb80 Compare April 5, 2022 18:04
@aucampia
Add tests for computing qname on invalid URIs
8fedc3f 
This change adds a test for functionality that is currently not being
tested.
@aucampia aucampia force-pushed the iwana-20220330T2346-test_ns_invalid_uri branch from 42ccb80 to 8fedc3f Compare April 5, 2022 18:27
@aucampia aucampia marked this pull request as ready for review April 5, 2022 18:27
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Apr 9, 2022
@aucampia aucampia merged commit 2ea84ec into RDFLib:master Apr 12, 2022
@aucampia aucampia deleted the iwana-20220330T2346-test_ns_invalid_uri branch April 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@nicholascar nicholascar Awaiting requested review from nicholascar

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees
No one assigned
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aucampia