[DO NOT REVIEW] Add a bunch of typing #1850
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
4 times, most recently
from
955b41f
to
beb89f0
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Apr 18, 2022
This PR adds a bunch of typing for rdflib.graph, mainly as a baseline for adding typing to rdflib.store which I will do next. I have resorted to using type aliases for typing all the functions, in part because it makes it easier to change in the future, however autodoc type hints do not work particularly well with this which is why I will switch to https://github.com/tox-dev/sphinx-autodoc-typehints in a separate patch. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
3 tasks
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
beb89f0
to
6f697fa
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Apr 18, 2022
This patch adds more type hints for rdflib.graph, mainly as a baseline for adding typing to rdflib.store which I will do next. I have resorted to using type aliases, in part because it makes it easier to change in the future and to keep everything consistent. One downside to the type aliases is that autodoc type hints do not work particularly well with this which is why I will switch to https://github.com/tox-dev/sphinx-autodoc-typehints in a separate patch. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Apr 18, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything cosnsitently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
6f697fa
to
6745ca6
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Apr 19, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything cosnsitently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
6745ca6
to
c3e431c
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
3 times, most recently
from
5e50fe0
to
3653f9c
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
3653f9c
to
39a98b0
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
May 21, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything cosnsitently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
5 times, most recently
from
1f0a8fc
to
0e04399
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
May 21, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything cosnsitently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
May 25, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything cosnsitently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behaviour. Broken off from RDFLib#1850
aucampia
added a commit
that referenced
this pull request
May 26, 2022
This patch primarily adds more type hints for `rdflib.graph`, but also adds type hints to some related modules in order to work with the new type hints for `rdflib.graph`. I'm mainly doing this as a baseline for adding type hints to `rdflib.store`. I have created type aliases to make it easier to type everything consistently and to make type hints easier easier to change in the future. The type aliases are private however (i.e. `_`-prefixed) and should be kept as such for now. This patch only contains typing changes and does not change runtime behavior. Broken off from #1850
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
0e04399
to
e44d849
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
2 times, most recently
from
8e745e0
to
92f43c3
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
692ea31
to
5e409eb
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Aug 14, 2022
More or less complete type hints for the rdflib.graph module. Other changes: - Improved/simplified type hints in `rdflib.store` and store plugins. - Add type ignores for various type errors that occur with the type hints. This is split-off from <RDFLib#1850>.
4 tasks
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Aug 14, 2022
More or less complete type hints for the rdflib.graph module. Other changes: - Improved/simplified type hints in `rdflib.store` and store plugins. - Add type ignores for various type errors that occur with the type hints. This is split-off from <RDFLib#1850>. This PR does not change runtime behaviour.
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
4 times, most recently
from
ffb6a1c
to
8296775
Compare
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Aug 21, 2022
More or less complete type hints for the rdflib.graph module. Other changes: - Improved/simplified type hints in `rdflib.store` and store plugins. - Add type ignores for various type errors that occur with the type hints. This is split-off from <RDFLib#1850>. This PR does not change runtime behaviour.
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Aug 21, 2022
More or less complete type hints for the rdflib.graph module. Other changes: - Improved/simplified type hints in `rdflib.store` and store plugins. - Add type ignores for various type errors that occur with the type hints. This is split-off from <RDFLib#1850>. This PR does not change runtime behaviour.
3 tasks
aucampia
added a commit
that referenced
this pull request
Aug 23, 2022
More or less complete type hints for the rdflib.graph module. Other changes: - Improved/simplified type hints in `rdflib.store` and store plugins. - Add type ignores for various type errors that occur with the type hints. This is split-off from <#1850>. This PR does not change runtime behaviour.
aucampia
added a commit
that referenced
this pull request
Aug 23, 2022
…2094) More or less complete type hints for `rdflib.plugins.sparql.algebra` and `rdflib.plugins.sparql.operators`. This does not change runtime behaviour. Other changes: - Fixed line endings of `test/test_issues/test_issue1043.py` and `test/test_issues/test_issue910.py`. - Removed a type hint comment that was present in rdflib/plugins/sparql/algebra.py This is split-off from #1850.
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
2 times, most recently
from
bb3775f
to
4ccf241
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
4ccf241
to
0679f89
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
0679f89
to
3eac68c
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
5 times, most recently
from
40e3b9d
to
47ab4f6
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
47ab4f6
to
ba44860
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
2 times, most recently
from
353ea9b
to
b4830ce
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
b4830ce
to
07963e8
Compare
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
2 times, most recently
from
1f9c8d8
to
a78c96d
Compare
[DO NOT REVIEW] Add a bunch of typing This is a branch I'm maintaing with a bunch of typing, I'm planning to integrate it with master in parts, anyone is welcome to have a look but most of what is happening here is subject to change.
aucampia
force-pushed
the
iwana-20220126T2212-typing
branch
from
a78c96d
to
2f8fe97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch I'm maintaing with a bunch of typing, I'm planning to
integrate it with master in parts, anyone is welcome to have a look but
most of what is happening here is subject to change.
Creating this pull request mainly go get docs built and verifying everything is working on all platforms.