Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add type hints to rdflib.graph #2080

Merged
merged 1 commit into from Aug 23, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

More or less complete type hints for the rdflib.graph module.

Other changes:

  • Improved/simplified type hints in rdflib.store and store plugins.
  • Add type ignores for various type errors that occur with the type
    hints.

This is split-off from #1850.

This PR does not change runtime behaviour.

A compact diff with non-runtime aspects stripped out can be found here.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20220814T2117-graph_typing branch from 87fc03a to 97f88d3 Compare August 14, 2022 22:26
@coveralls
Copy link

coveralls commented Aug 14, 2022

Coverage Status

Coverage decreased (-0.006%) to 90.456% when pulling e638690 on aucampia:iwana-20220814T2117-graph_typing into a70a9c8 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review August 14, 2022 22:42
@aucampia aucampia requested a review from a team August 15, 2022 07:14
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Aug 15, 2022
@aucampia aucampia force-pushed the iwana-20220814T2117-graph_typing branch from 97f88d3 to be2d059 Compare August 21, 2022 19:10
More or less complete type hints for the rdflib.graph module.

Other changes:
- Improved/simplified type hints in `rdflib.store` and store plugins.
- Add type ignores for various type errors that occur with the type
  hints.

This is split-off from <RDFLib#1850>.

This PR does not change runtime behaviour.
@aucampia aucampia force-pushed the iwana-20220814T2117-graph_typing branch from be2d059 to e638690 Compare August 21, 2022 19:12
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 256e9a2 into RDFLib:master Aug 23, 2022
@aucampia aucampia deleted the iwana-20220814T2117-graph_typing branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants