Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More type hints for rdflib.graph and related #1853

Merged
merged 3 commits into from
May 26, 2022
Merged

More type hints for rdflib.graph and related #1853

merged 3 commits into from
May 26, 2022

Commits on May 25, 2022

  1. More type hints for rdflib.graph and related 

    This patch primarily adds more type hints for `rdflib.graph`, but also
adds type hints to some related modules in order to work with the new
type hints for `rdflib.graph`.

I'm mainly doing this as a baseline for adding type hints to
`rdflib.store`.

I have created type aliases to make it easier to type everything
cosnsitently and to make type hints easier easier to change in the
future. The type aliases are private however (i.e. `_`-prefixed) and
should be kept as such for now.

This patch only contains typing changes and does not change runtime
behaviour.

Broken off from RDFLib#1850
    @aucampia
    aucampia committed May 25, 2022
    Configuration menu
    Copy the full SHA
    31c8d4c View commit details
    Browse the repository at this point in the history

  2. Changes from review: 

    - Fixed second overload of `_TripleType` to return `Path` instead of
  `_PredicateType`.
    @aucampia
    aucampia committed May 25, 2022
    Configuration menu
    Copy the full SHA
    434dc33 View commit details
    Browse the repository at this point in the history

  3. Additional fixes 

    Changed type hints based on more information discovered in mean time.
    @aucampia
    aucampia committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a79650d View commit details
    Browse the repository at this point in the history