Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trix parser #1966

Merged
merged 7 commits into from May 25, 2022
Merged

Fix trix parser #1966

merged 7 commits into from May 25, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2022

Summary of changes

Changed TriX parser to allow trix and TriX

The RDFLib TriX parser currently only accepts TriX documents conforming to the the Nokia-published XSD which specifies (the mixed-case) TriX, contradicting the W3C-published XSD spec for TriX which specifies (the lower-case) trix. We should accept both.

We were also a bit light on a TriX test suite for exercising the parser, so I recruited some TriX test fixtures from NG4J and Jena and fleshed out the TriX test suite, using the W3C "Manifest"-style approach.

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented May 21, 2022

Coverage Status

Coverage increased (+0.06%) to 88.501% when pulling cc12c4c on gjhiggins:fix-trix-parser into a3a4611 on RDFLib:master.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good and nice to have the additional tests, just some minor notes on naming.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aucampia aucampia requested a review from a team May 21, 2022 17:55
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 21, 2022
@aucampia
Copy link
Member

Will merge by 2022-05-25 if there is no further feedback. This is a very simple fix.

@aucampia aucampia merged commit 8e24878 into RDFLib:master May 25, 2022
@ghost ghost deleted the fix-trix-parser branch May 26, 2022 10:02
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants