-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trix parser #1966
Fix trix parser #1966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good and nice to have the additional tests, just some minor notes on naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Will merge by 2022-05-25 if there is no further feedback. This is a very simple fix. |
Summary of changes
Changed TriX parser to allow
trix
andTriX
The RDFLib TriX parser currently only accepts TriX documents conforming to the the Nokia-published XSD which specifies (the mixed-case)
TriX
, contradicting the W3C-published XSD spec for TriX which specifies (the lower-case)trix
. We should accept both.We were also a bit light on a TriX test suite for exercising the parser, so I recruited some TriX test fixtures from NG4J and Jena and fleshed out the TriX test suite, using the W3C "Manifest"-style approach.
Checklist
so maintainers can fix minor issues and keep your PR up to date.