test: remove python 2.4 specific behaviour in test #2040

aucampia · 2022-07-19T22:10:37Z

Summary of changes

Remove some python 2.4 specific code as we don't support python 2.4
anymore.

Checked that there aren't other open pull requests for
the same change.
Checked that all tests and type checking passes.
Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.

aucampia · 2022-07-19T22:48:08Z

This is failing because of fix: import xml.sax.handler from the right place #2041 - once that PR is merged this can be rebased and then it will pass.

Remove some python 2.4 specific code as we don't support python 2.4 anymore.

coveralls · 2022-07-20T13:35:51Z

Coverage remained the same at 90.445% when pulling 6d20ab4 on iwana-20220720T0007-cleanup_py2 into 93963ee on master.

ghost

long overdue, one feels 😄

aucampia marked this pull request as ready for review July 19, 2022 22:10

aucampia marked this pull request as draft July 19, 2022 22:12

aucampia force-pushed the iwana-20220720T0007-cleanup_py2 branch 2 times, most recently from ec9bfa5 to 8f25a94 Compare July 19, 2022 22:44

aucampia marked this pull request as ready for review July 19, 2022 22:47

aucampia requested a review from a team July 19, 2022 22:48

test: remove python 2.4 specific behaviour in test

6d20ab4

Remove some python 2.4 specific code as we don't support python 2.4 anymore.

aucampia force-pushed the iwana-20220720T0007-cleanup_py2 branch from 8f25a94 to 6d20ab4 Compare July 20, 2022 13:08

ghost approved these changes Jul 20, 2022

View reviewed changes

aucampia merged commit a2f96bc into master Jul 20, 2022

aucampia deleted the iwana-20220720T0007-cleanup_py2 branch July 21, 2022 21:27