fix: import xml.sax.handler from the right place #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the import of `xml.sax.handler` in the TriX parser so that it imports from `xml.sax` and not from `xml.sax.saxutils`. Importing from `xml.sax.saxutils` causes mypy to fail but it is also wrong as there is no documented `handler` in `xml.sax.saxutils`.
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Change the import of
xml.sax.handlerin the TriX parser so that itimports from
xml.saxand not fromxml.sax.saxutils. Importing fromxml.sax.saxutilscauses mypy to fail but it is also wrong as there isno documented
handlerinxml.sax.saxutils.Checklist
the same change.
CHANGELOG.md).so maintainers can fix minor issues and keep your PR up to date.