chore: remove pre python 3.5 regex related workaround #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing a pre-python 3.5 regex related workaround as it uses a private method from the `re` module, and mypy complains about this, it is also no longer needed as we no longer support pre 3.5 versions of python. No tests are added as all changed parts of the `Builtin_REPLACE` function is already covered by existing tests.
aucampia
force-pushed
the
iwana-20220720T0011-cleanup_py35
branch
from
55fbdff
to
fd9a3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removing a pre-python 3.5 regex related workaround as it uses a private
method from the
remodule, and mypy complains about this, it is alsono longer needed as we no longer support pre 3.5 versions of python.
No tests are added as all changed parts of the
Builtin_REPLACEfunction is already covered by existing tests.
Checklist
the same change.
CHANGELOG.md).so maintainers can fix minor issues and keep your PR up to date.