feat: more type hints for rdflib.plugins.sparql
#2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a roundabout reason why this matters now, but basically: I want to add examples for securing RDFLib with `sys.addaudithook` and `urllib.request.install_opener`. I also want to be sure examples are actually valid, and runnable, so I was adding static analysis and simple execution of examples to our CI. During this I noticed that examples use `initBindings` with `Dict[str,...]`, which was not valid according to mypy, but then after some investigation I realized the type hints in some places were too strict. So the main impetus for this is actually to relax the type hints in `rdflib.graph`, but to ensure this is valid I'm adding a bunch of type hints I had saved up to `rdflib.plugins.sparql`. Even though this PR looks big, it has no runtime changes.
aucampia
force-pushed
the
iwana-20230312T1355-type_sparql
branch
from
911d3a3
to
176d4d3
Compare
aucampia
added
review wanted
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A bit of a roundabout reason why this matters now, but basically:
I want to add examples for securing RDFLib with
sys.addaudithookandurllib.request.install_opener. I also want to be sure examples are actually valid, and runnable, so I was adding static analysis and simple execution of examples to our CI.During this I noticed that examples use
initBindingswithDict[str,...], which was not valid according to mypy, but then after some investigation I realized the type hints in some places were too strict.So the main impetus for this is actually to relax the type hints in
rdflib.graph, but to ensure this is valid I'm adding a bunch of type hints I had saved up tordflib.plugins.sparql.Even though this PR looks big, it has no runtime changes, as can be seen from the compact diff here.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.