fix: validation issues with examples #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20230312T1056-validate_examples
branch
from
917b312
to
1f8cc6d
Compare
aucampia
added
review wanted
aucampia
force-pushed
the
iwana-20230312T1056-validate_examples
branch
from
1f8cc6d
to
72de11f
Compare
3 tasks
I want to add examples for securing RDFLib network access using `sys.addaudithook` and `urllib.request.install_opener`, but I want to also validate the examples in our CI pipeline, so we can demonstrate they work to our users. This change adds validation for all examples, and the addition of the security examples in a seperate PR will then also get validated.
aucampia
force-pushed
the
iwana-20230312T1056-validate_examples
branch
from
72de11f
to
7032597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I want to add examples for securing RDFLib network access using
sys.addaudithookandurllib.request.install_opener, but I want toalso validate the examples in our CI pipeline, so we can demonstrate
they work to our users.
This change adds validation for all examples, and the addition of the
security examples in a separate PR will then also get validated.
This change also fixes any validation issues for the examples.
rdflib.plugins.sparql#2268, so to get a accurate picture of the changes, have a look at aucampia/rdflib@iwana-20230312T1355-type_sparql...iwana-20230312T1056-validate_examplesChecklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.