adding python 3.5 support #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise our workaround for http://bugs.python.org/issue1519638 fails on py3.5+
|
|
||
| compat_r = unicode(replacement) if sys.version_info[:2] >= (3, 5) else _r | ||
|
|
||
| return Literal(re.sub(unicode(pattern), compat_r, text, cFlag), |
There was a problem hiding this comment.
@gjhiggins could you review this? i'm not sure this is the best / a good solution
There was a problem hiding this comment.
it's not pretty - and should maybe somehow be in compat.py - but if it works, SHIPIT!
but maybe add a comment? :)
joernhees
changed the title
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.