fixed issue #535 #536
Merged
fixed issue #535 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR, seems the failing py3 build is unrelated to this, but rather related to SPARQLWrapper's failing dependency on urlgrabber in py3... |
joernhees
added
bug
|
re-running tests after SPARQLWrapper 1.7.1 release... |
| def test_nquads_default_graph(): | ||
| ds = ConjunctiveGraph() | ||
|
|
||
| src = StringInputSource(""" |
There was a problem hiding this comment.
can you try changing this to data = """...
|
test fails on py3, can you try passing the string via |
This was referenced Mar 16, 2017
ghost
mentioned this pull request
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make a choice in how this issue was fixed:
I decided that the "default graph" for the parser was the one identified by the publicID passed to the
parsemethod, which seems to make sense.