Test-suite and bug-fixes for AuditableStore (cleaned history) #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the underlying store is not transaction_aware, then calling its commit method has no effect anyway. If the underlying store *is* transaction_aware, then it may contain more pending changes than those recorded by the AuditableStore, and committing them is a mistake. This is illustrated by test/test_auditable.py:TestAuditableStoreEmbeded .
|
Looks good! Thanks! |
gromgull
added a commit
that referenced
this pull request
Nov 30, 2015
Test-suite and bug-fixes for AuditableStore (cleaned history)
joernhees
added
bug
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a squashed version of #537 .
@gromgull I only squashed those commits fixing the test-suite, which indeed didn't look good. However, I kepts separate the commit creating the tests suite, and the different steps in fixing AuditableStore so as to pass the suite. I think it is better that way, but if you prefer, I can also squash all of them into a single commit.