removing pyparsing version requirement #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versioning requirement was put in place 4 years ago to handle older versions of Python. setuptools no longer supports pyparsing < 2.1, so we'll need to adhere to that to continue using pip.
|
While we're here, there's still code for this 2.5 requirement in setup.py. It can probably be left there for any users trying to install via setup.py, but 2.5 appears to not have been supported for almost 2 years now. Edit: This change also means that requirements could be reduced to a single requirements.txt file if that was desired. |
|
thanks! |
|
I would say we should clean up setup.py as well - it's not super urgent though. |
joernhees
added
enhancement
joernhees
added a commit
that referenced
this pull request
Jan 25, 2017
* master: (44 commits) quote cleanup OCD serializer/parser alias for 'ntriples' serializer/parser alias for 'ttl' cleanup remove outdated always skipped test a bit of changelog add a NTSerializer sub-class for nt11 (#700) Restrict normalization to unicode-compatible values (#674) fixes for turtle/trig namespace handling skip serialising empty default graph skip round-trip test, unfixable until 5.0 prefix test for #428 Added additional trig unit tests to highlight some currently occurring issues. remove ancient and broken 2.3 support code. (#681) updating deprecated testing syntax (#697) docs: clarify the use of an identifier when persisting a triplestore (#654) removing pyparsing version requirement (#696) made min/max aggregate functions support all literals (#694) actually fix projection from sub-queries added dawg tests for #607 ...
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioning requirement was put in place 4 years ago to handle older
versions of Python. setuptools no longer supports pyparsing < 2.1, so
we'll need to adhere to that to continue using pip or put a hard version
on pip. This seems like the more reasonable approach.