Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye, rdflib-jsonld #174

Merged
merged 5 commits into from
Jan 7, 2022
Merged

Goodbye, rdflib-jsonld #174

merged 5 commits into from
Jan 7, 2022

Conversation

eggplants
Copy link
Contributor

rdflib 6.0.1 had marged rdflib-jsonld. So I say goodbye to rdflib-jsonld.

@aucampia
Copy link
Member

aucampia commented Jan 4, 2022

Thanks for the PRs, I will reivew as soon as I have some time, hopefully tonight or tomorrow night (CET)

@nicholascar
Copy link
Member

Please bump the RDFlib requirements up further to 6.1.1, not 6.0.1. The later version has a few important fixes

@eggplants
Copy link
Contributor Author

𝙍𝙚𝙖𝙙𝙮 𝙛𝙤𝙧 𝙧𝙚𝙫𝙞𝙚𝙬…

@aucampia
Fix python version constraints
325dd1c 
RDFLib 6.x does not support python versions earlier than 3.7.
aucampia
aucampia approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, looks good, apologies for not getting to a review earlier. I changed the python version constraint to match.

nicholascar
nicholascar approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nicholascar nicholascar merged commit e95a026 into RDFLib:master Jan 7, 2022
@eggplants eggplants deleted the jsonld branch January 7, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

@nicholascar nicholascar nicholascar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggplants @aucampia @nicholascar