Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Folder creating multiple folders #273

Closed
6 tasks done
bbashy opened this issue Sep 30, 2016 · 8 comments
Closed
6 tasks done

Persistent Folder creating multiple folders #273

bbashy opened this issue Sep 30, 2016 · 8 comments

Comments

@bbashy
Copy link
Contributor

bbashy commented Sep 30, 2016

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

  • You're running the latest release version of Deployer.
  • Ensure that you're running at least PHP 5.5.9, you can check this by running php -v
  • You've ran composer install --no-dev from the root of your installation.
  • You've ran npm install --production from the root of your installation.
  • You've ran rm -rf bootstrap/cache/* from the root of your installation.
  • You have restarted the queue listener and node socket server.

To help us better understand your issue, please answer the following.

Expected behaviour

Symlinks a folder/file (defined) to the shared directory

Actual behaviour

I'm trying to link the storage folder (Laravel) and have it persistent over each release. It seems to be duplicating the folder on each deploy like it's copying it then symlinking.

I have this folder structure;

shared
->storage
-->storage (created each deploy)

The symlink works correctly and points to the 1 level deep folder.

# ls -lah
storage -> /var/www/project/shared/storage

Steps to reproduce

  • Add project.
  • Add folder (that exists in the repo) to files tab in deployer.
  • Deploy

Environment info

For both deployer and web servers
Operating System: Debian Jessie 64
PHP Version: PHP 7.0.11-1

@REBELinBLUE
Copy link
Owner

Hmm, interesting. Which distro/version of Linux are you using on the server you are deploying to?

@bbashy
Copy link
Contributor Author

bbashy commented Sep 30, 2016

Debian Jessie 64
PHP 7.0.11-1

Had it on two different servers now. Could be something I'm doing wrong as the duplicate folder isn't ever used and looks like the default in Laravel (with no cache/session files).

@REBELinBLUE
Copy link
Owner

Interesting, that sounds like exactly the same setup as my test VMs. i'll have a play around this evening and see if I can recreate it

@bbashy
Copy link
Contributor Author

bbashy commented Sep 30, 2016

I believe I tried both /storage/ and storage/ but you could test that also.

Thanks for the swift response 👍

@bbashy
Copy link
Contributor Author

bbashy commented Oct 5, 2016

Not sure what you've looked into yet but this could be it: https://github.com/REBELinBLUE/deployer/blob/master/resources/scripts/deploy/ShareDirectory.sh#L3

@bbashy
Copy link
Contributor Author

bbashy commented Oct 10, 2016

Definitely that copy command. Getting this when I set shared folder to nginx user/group.

cp: cannot create directory ‘/home/user/project/shared/storage/storage’: Permission denied

@REBELinBLUE
Copy link
Owner

Hey, sorry for the late reply, I have been on holiday the last few weeks without a net connection. I will take a look at this issue this evening

@bbashy
Copy link
Contributor Author

bbashy commented Oct 19, 2016

No problem! It's not made deployments fail but an interesting issue.

If you need any logs or info, let me know.

@REBELinBLUE REBELinBLUE added this to the 0.0.39 milestone Oct 21, 2016
@REBELinBLUE REBELinBLUE changed the title Persistent Folder creating multiple folders? Persistent Folder creating multiple folders Oct 23, 2016
REBELinBLUE added a commit that referenced this issue Oct 23, 2016
* master: (42 commits)
  Updated CHANGELOG
  Fixes #273 by not copying the shared folder/file from the release if it has already been copied
  Re-added postgres env
  Testing only 1 env
  Test
  Test
  Changed cat command for travis
  Fix code climate issues
  Changed build image
  Fixes #275 by checking that the --no-suggest option exists before attempting to use it
  Fixes #276 - Allows the passphrase for the private key to be set
  Fixed missing reason of rollback (#270)
  Updated dependencies
  Updated dependencies
  Update README.md
  Update README.md
  Update README.md
  Update README.md
  Last chance
  Setting a random JWT
  ...
@REBELinBLUE REBELinBLUE removed this from the 0.0.39 milestone Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants