Prioritise WS for optimal transport #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to `/.well-known/` is allowed RFC5785
| @@ -39,7 +39,8 @@ toastr.options.extendedTimeOut = 7000; | |||
| app.project_id = app.project_id || null; | |||
|
|
|||
| app.listener = io.connect($('meta[name="socket_url"]').attr('content'), { | |||
| query: 'jwt=' + $('meta[name="jwt"]').attr('content') | |||
| query: 'jwt=' + $('meta[name="jwt"]').attr('content'), | |||
| transports: ['websocket', 'polling'] | |||
There was a problem hiding this comment.
Isn't that the default option?
There was a problem hiding this comment.
REBELinBLUE
added a commit
that referenced
this pull request
Jul 23, 2016
* master: Updated dependencies Priority WS for optimal transport browser (#250) Ignore suggestions when installing Composer deps (#252) Fix style issue Revert "[Snyk Alert] Fix for 2 vulnerable dependency paths" (#245) fix: package.json & .snyk to reduce vulnerabilities (#244) Conflicts: composer.lock resources/assets/js/app.js
REBELinBLUE
changed the title
REBELinBLUE
added a commit
that referenced
this pull request
Aug 6, 2016
* master: (60 commits) Updated CHANGELOG Fixes #257 - Touch files when extracting to prevent warnings about timestamps Update README.md Added a note about a common error Updated ioredis Updated google2fa library Fixes #254 Fixes #256 - Git tag names causing a fatal error if they are not valid version string Fixed gulpfile so that assets don't get removed before they are versioned Updated dependencies Updated dependencies Priority WS for optimal transport browser (#250) Ignore suggestions when installing Composer deps (#252) Fix style issue Revert "[Snyk Alert] Fix for 2 vulnerable dependency paths" (#245) fix: package.json & .snyk to reduce vulnerabilities (#244) Handling the timeout checking for an update on github, i.e. when I am at work behind a proxy Added a check to the updatre script to ensure npm install has been run Update dialog.blade.php (#239) Silence PHPMD ...
REBELinBLUE
changed the title
REBELinBLUE
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Description of change
Without these changes, we will always be
pullingeven if there is implementation ofwebsocket./.well-known/is allowed RFC5785 (Let's Encrypt).app.listener = io.connect($('meta[name="socket_url"]').attr('content'), { query: 'jwt=' + $('meta[name="jwt"]').attr('content'), + transports: ['websocket', 'polling'] });