Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IETF API-Problem specification for error messages #49

Closed
wants to merge 6 commits into from
Closed

IETF API-Problem specification for error messages #49

wants to merge 6 commits into from

Conversation

e0ipso
Copy link
Member

@e0ipso e0ipso commented May 28, 2014

Implements #27.

@e0ipso e0ipso mentioned this pull request May 28, 2014
Closed
@amitaibu
Copy link
Member

@cpliakas - how cool is that? :)

@e0ipso
Copy link
Member Author

e0ipso commented May 28, 2014

Tests fixed.

amitaibu
amitaibu reviewed May 28, 2014
View reviewed changes
exceptions/RestfulException.php
public function getType() {
// Depending on the error code we'll return a different URL.
$url = 'http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html';
$sections = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are crazy! ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some HTML c&p and text editor magic did the trick, and it adheres to the proposal! Also, bonus for linking to W3.org.

@amitaibu
Copy link
Member

Code looks good, I think before merge it's worth adding a line or two in the README - care to do it?

@e0ipso
Copy link
Member Author

e0ipso commented May 28, 2014

Right! The section about Error Hnadling needs to be updated.

On Wed, May 28, 2014 at 8:13 PM, Amitai Burstein
notifications@github.comwrote:

Code looks good, I think before merge it's worth adding a line or two in
the README - care to do it?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/49#issuecomment-44444384
.

Mateu Aguiló Bosch.
Developer.

w. lb.cm/e0ipso
e. mateu@lullabot.com
skype. mateu.aguilo.bosch
irc. e0ipso

Mateu Aguiló Bosch added 2 commits May 28, 2014 21:31
@e0ipso
Copy link
Member Author

e0ipso commented May 28, 2014

Added README notes.

@e0ipso
Copy link
Member Author

e0ipso commented May 28, 2014

This should be good to merge.

@amitaibu amitaibu mentioned this pull request May 29, 2014
Closed
@amitaibu
Copy link
Member

Merged, thanks!

@amitaibu amitaibu closed this May 29, 2014
@cpliakas
Copy link
Contributor

cpliakas commented Jun 2, 2014

@mateu-aguilo-bosch Great work!

@amitaibu, thanks for being open to this change and committing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e0ipso @amitaibu @cpliakas