Add file upload resource

[amitaibu]

#56

[amitaibu]

@mateu-aguilo-bosch any idea how to write tests for this? :)

[amitaibu]

To enable feature:
drush vset restful_file_upload 1

To allow anonymous users to upload:
drush vset restful_file_upload_allow_anonymous_user 1

[amitaibu]

@mateu-aguilo-bosch just confirming this logic looks ok to you.

[e0ipso]

I think it would be better to have an authorizer manager (for the request level access, not the entity level) that it's instantiated from a restful-level generic menu access callback. That would simplify testing for user access to hook_menu generated items.

Something like:

function hook_menu() {
  $items['…'] = array(
    …
    'access callback' => 'restful_menu_access_authorization',
    …
  );
  $items['…']['access arguments'] = $items['…']['page arguments'] + array('custom option1', 'custom option2');
  return $items;
}

…

function restful_menu_access_authorization($plugin_type, $version) {
  $additional_args = array_slice(2, func_get_args());
  $authorizerManager = \RestfulBase::authorizerManager($plugin_type, $version, $additional_args);
  return $authorizerManager->authorize();
}

[amitaibu]

I prefer to get this in, as figuring out the tests might take some time - we can deal with that in a follow up.

Merged.

[e0ipso]

👍 Let's open a new issue then.

[amitaibu]

Opened #88

[e0ipso]

Maybe we can do this instead to have return type consistency:

return variable_get('restful_file_upload_allow_anonymous_user', FALSE) || !!$user->uid;

[amitaibu]

meh, it's already working :)