Evaluate minEvents gating argument for CytoExploreR. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejiang
approved these changes
May 14, 2024
|
Thank you for the investigation&&patch |
|
pushed to bioconductor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikejiang, a recent change in the latest version of R is causing issues for CytoExploreR.
I've tracked down the issue as described in this ticket.
Basically all gating arguments are passed in as
callswhich get automatically evaluated during thisdo.call()chunk which invokes the gating function. TheminEventsargument is dropped from this list and therefore remains acallwhen the event number check is performed.To be safe I have wrapped the
callevaluation in an if statement.Adding @mikejiang for review as this fix is required on BioC for CytoExploreR to work - first reported here.