Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Add initial tests #61

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Add initial tests #61

merged 2 commits into from
Jun 4, 2018

Conversation

major
Copy link
Contributor

@major major commented May 31, 2018

This PR adds initial tests for sktm and uses pytest to run them. We can run the tests with plain unittest later, but pytest gives us some nice features we could use.

@major major added the enhancement New feature or request label May 31, 2018
@major major self-assigned this May 31, 2018
@major major force-pushed the first-tests branch 5 times, most recently from 68b4c43 to f4acfe1 Compare May 31, 2018 16:53
@major
Copy link
Contributor Author

major commented May 31, 2018

The coverage report is a bit ugly since there is no test coverage from previous commits. ;)

@danghai
Copy link
Contributor

danghai commented May 31, 2018

Hi @major , it is good to use coverage the same as skt use. What do you think?

@major
Copy link
Contributor Author

major commented May 31, 2018

@danghai I was using coveralls, but their bot that posts feedback in the PR has been causing issues lately.

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@eeeda05). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #61   +/-   ##
========================================
  Coverage          ?   23.6%           
========================================
  Files             ?       5           
  Lines             ?     915           
  Branches          ?       0           
========================================
  Hits              ?     216           
  Misses            ?     699           
  Partials          ?       0
Impacted Files Coverage Δ
tests/test_init.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeeda05...d6672a8. Read the comment docs.

@major major force-pushed the first-tests branch 2 times, most recently from 25dfd6b to fd7037f Compare June 1, 2018 15:14
@major major force-pushed the first-tests branch 2 times, most recently from b82d033 to 50a043a Compare June 4, 2018 14:14
@major major mentioned this pull request Jun 4, 2018
1 task
major added 2 commits June 4, 2018 11:37
Signed-off-by: Major Hayden <major@redhat.com>
Copy link
Contributor

@dzickusrh dzickusrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine as a start. I filed issue #70 to track small changes later.

@dzickusrh dzickusrh merged commit 7ec0926 into cki-project:master Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants