-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
68b4c43
to
f4acfe1
Compare
The coverage report is a bit ugly since there is no test coverage from previous commits. ;) |
Hi @major , it is good to use |
@danghai I was using coveralls, but their bot that posts feedback in the PR has been causing issues lately. |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
========================================
Coverage ? 23.6%
========================================
Files ? 5
Lines ? 915
Branches ? 0
========================================
Hits ? 216
Misses ? 699
Partials ? 0
Continue to review full report at Codecov.
|
25dfd6b
to
fd7037f
Compare
b82d033
to
50a043a
Compare
Signed-off-by: Major Hayden <major@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine as a start. I filed issue #70 to track small changes later.
This PR adds initial tests for sktm and uses
pytest
to run them. We can run the tests with plainunittest
later, butpytest
gives us some nice features we could use.