You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The removed-rules test doesn't really fit the diff category - all other tests are expected to fail + failures reviewed manually, but removed-rules works more like a traditional regression test, it should never fail.
Moving it outside would mean breaking access to shared (which includes "get me old content" logic), which is why I was reluctant to do that so far.
However we now need other tests with access to that functionality - namely the replacement for Sanity/test-hardening-pkg-update which should not be in diff anyway.
So
move the shared functionality to somewhere in lib
move removed-rules out of diff, into /static-checks
create a replacement for Sanity/test-hardening-pkg-update (in /hardening probably) using the functionality
The text was updated successfully, but these errors were encountered:
The
removed-rules
test doesn't really fit thediff
category - all other tests are expected to fail + failures reviewed manually, butremoved-rules
works more like a traditional regression test, it should never fail.Moving it outside would mean breaking access to
shared
(which includes "get me old content" logic), which is why I was reluctant to do that so far.However we now need other tests with access to that functionality - namely the replacement for
Sanity/test-hardening-pkg-update
which should not be indiff
anyway.So
shared
functionality to somewhere inlib
removed-rules
out ofdiff
, into/static-checks
Sanity/test-hardening-pkg-update
(in/hardening
probably) using the functionalityThe text was updated successfully, but these errors were encountered: