Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /static-checks/diff/removed-rules out of diff + provide shared in lib #187

Closed
comps opened this issue May 9, 2024 · 1 comment
Closed

Comments

@comps
Copy link
Contributor

comps commented May 9, 2024

The removed-rules test doesn't really fit the diff category - all other tests are expected to fail + failures reviewed manually, but removed-rules works more like a traditional regression test, it should never fail.

Moving it outside would mean breaking access to shared (which includes "get me old content" logic), which is why I was reluctant to do that so far.

However we now need other tests with access to that functionality - namely the replacement for Sanity/test-hardening-pkg-update which should not be in diff anyway.

So

  1. move the shared functionality to somewhere in lib
  2. move removed-rules out of diff, into /static-checks
  3. create a replacement for Sanity/test-hardening-pkg-update (in /hardening probably) using the functionality
@comps
Copy link
Contributor Author

comps commented Jun 4, 2024

Fixed by #196

@comps comps closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant