Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max. packet length for AT86RF2XX #3086

Closed
PeterKietzmann opened this issue May 27, 2015 · 22 comments
Closed

Max. packet length for AT86RF2XX #3086

PeterKietzmann opened this issue May 27, 2015 · 22 comments
Assignees
Labels
Area: drivers Area: Device drivers Area: network Area: Networking State: don't stale State: Tell state-bot to ignore this issue Type: question The issue poses a question regarding usage of RIOT

Comments

@PeterKietzmann
Copy link
Member

EDIT:
The issue was fixed with #3480. However, #3480 limits the maximum payload in a (transceiver-)packet, by keeping the theoretically maximum MAC-header length of 25 Bytes free. Ideally we want a dynamic solution that computes the actual MAC-header length (which may be shorter than 25 Bytes), to fill all packets with payload completely.

OLD:
In ng_sixlowpan the max. packet size NETCONF_OPT_MAX_PACKET_SIZE is requested from the hardware device which correlates with the max. fragment size of a 6LoWPAN packet. It is the basis for 6LoWPAN fragmentation, if payloads are too long. In the art86rfxx netdev-driver the device returns the value NG_AT86RF2XX_MAX_PKT_LENGTH (127). In the drivers _send function it is checked if the transceivers max. packet length plus FCS check sequence plus 802.15.4 header length is greater than the transceivers max. fifo size.
What I'm saying is: Shouldn't we return the max. packet size minus link layer header lengths to the 6LoWPAN fragmentation? Or do I get confused somewhere between fragmentation, header lengths and the transceivers fifo size?

@PeterKietzmann PeterKietzmann added Type: question The issue poses a question regarding usage of RIOT Area: drivers Area: Device drivers NSTF labels May 27, 2015
@PeterKietzmann PeterKietzmann added this to the Release 2015.06 milestone May 27, 2015
@miri64
Copy link
Member

miri64 commented May 27, 2015

At least xbee seems to do it the way you describe it, so I guess you are right :D

@PeterKietzmann
Copy link
Member Author

For the record: #3480

@PeterKietzmann
Copy link
Member Author

@OlegHahm I quickly adapted the issue-discription. Can you please read it and check if one understands the problem?

@jnohlgard
Copy link
Member

I understand the edited problem statement.

@OlegHahm
Copy link
Member

@PeterKietzmann, yes, I think it's comprehensible.

Btw. I discussed yesterday shortly with @authmillenon and we concluded that basically everything except the destination address length should be known to the link layer/transceiver driver.

@PeterKietzmann
Copy link
Member Author

Among others, the function _make_data_frame_hdr checks for the header flags NG_NETIF_HDR_FLAGS_BROADCAST and/or NG_NETIF_HDR_FLAGS_MULTICAST. Is this known by the driver?

@OlegHahm OlegHahm modified the milestones: Release 2015.09, Release NEXT MAJOR Oct 22, 2015
@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 2, 2015
@OlegHahm
Copy link
Member

@authmillenon, how is the situation in the new (netdev2) driver version?

@miri64
Copy link
Member

miri64 commented Feb 24, 2016

Nothing yet, but since netdev2 centralizes this, doing this should be quite easy.

@miri64
Copy link
Member

miri64 commented Feb 24, 2016

But I would vote against doing it in #4646.

@OlegHahm
Copy link
Member

But I would vote against doing it in #4646.

Agreed!

@kYc0o
Copy link
Contributor

kYc0o commented Aug 4, 2016

We leave this issue open until is fully solved?

@miri64
Copy link
Member

miri64 commented Aug 4, 2016

It's not solved yet, so yes ;-)

@miri64
Copy link
Member

miri64 commented Oct 31, 2016

Again postponed.

@miri64 miri64 modified the milestones: Release 2017.01, Release 2016.10 Oct 31, 2016
@miri64
Copy link
Member

miri64 commented Nov 10, 2016

Mhhh… this is more of an enhancement by now, not an issue => postponed.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale
Copy link

stale bot commented Feb 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Feb 11, 2020
@miri64
Copy link
Member

miri64 commented Feb 11, 2020

@jia200x might be of interest for you?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Feb 11, 2020
@jia200x
Copy link
Member

jia200x commented Feb 11, 2020

yes! Thanks!

@jia200x jia200x self-assigned this Feb 11, 2020
@stale
Copy link

stale bot commented Aug 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 14, 2020
@stale stale bot closed this as completed Sep 15, 2020
@jia200x jia200x reopened this Sep 15, 2020
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Sep 15, 2020
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 19, 2021
@stale stale bot closed this as completed Jun 3, 2021
@jeandudey jeandudey added State: don't stale State: Tell state-bot to ignore this issue and removed State: stale State: The issue / PR has no activity for >185 days labels Jun 3, 2021
@jeandudey jeandudey reopened this Jun 3, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 22, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@maribu
Copy link
Member

maribu commented Sep 16, 2022

ping?

@maribu
Copy link
Member

maribu commented May 17, 2023

If I understand correctly this goes in the same direction as #19132.

Normally, it is common procedure to close the new issues as duplicates of the old. In this case, I think the new issue is more general and this one a subset of the new issue. Hence, I'd like to close the old one here instead.

Please reopen if you disagree.

@maribu maribu closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking State: don't stale State: Tell state-bot to ignore this issue Type: question The issue poses a question regarding usage of RIOT
Projects
None yet
Development

No branches or pull requests