sys/newlib: Update _read_r and _write_r to match newlib prototypes in reent.h #5249
Conversation
jnohlgard
added
Type: bug
| @@ -186,7 +186,7 @@ int _open_r(struct _reent *r, const char *name, int flags, int mode) | |||
| * | |||
| * @return TODO | |||
| */ | |||
| int _read_r(struct _reent *r, int fd, void *buffer, unsigned int count) | |||
| _ssize_t _read_r(struct _reent *r, int fd, void *buffer, size_t count) | |||
There was a problem hiding this comment.
Has nothing to do with this PR, but what's the difference between _ssize_t and ssize_t?
There was a problem hiding this comment.
I think it's just because newlib doesn't want to pollute the namespace and only defines names starting with underscore. There's a typedef in the cross toolchain headers typedef ssize_t _ssize_t.
There was a problem hiding this comment.
Basically there is no difference. sys/_types.h defines _ssize_t, and sys/types.h then does typedef _ssize_t ssize_t. sys/types.h transcludes further headers, and I guess _ssize_t is used in prototypes to keep transclusions cycle free, i.e. the headers only have to depend on sys/_types.h.
|
ACK and go! |
|
might this also need a backport? |
|
Wasn't this merged before the release candidate fork?
|
|
Yes sorry
|
Another bugfix for the newlib syscalls. Fixes an error message when running
make scan-buildwith TOOLCHAIN=gnuSee also reent.h in your local cross toolchain installation