Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/newlib: Update _read_r and _write_r to match newlib prototypes in reent.h #5249

Merged
merged 1 commit into from
Apr 6, 2016
Merged

sys/newlib: Update _read_r and _write_r to match newlib prototypes in reent.h #5249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sys/newlib/syscalls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ int _open_r(struct _reent *r, const char *name, int flags, int mode)
*
* @return TODO
*/
int _read_r(struct _reent *r, int fd, void *buffer, unsigned int count)
_ssize_t _read_r(struct _reent *r, int fd, void *buffer, size_t count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has nothing to do with this PR, but what's the difference between _ssize_t and ssize_t?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just because newlib doesn't want to pollute the namespace and only defines names starting with underscore. There's a typedef in the cross toolchain headers typedef ssize_t _ssize_t.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically there is no difference. sys/_types.h defines _ssize_t, and sys/types.h then does typedef _ssize_t ssize_t. sys/types.h transcludes further headers, and I guess _ssize_t is used in prototypes to keep transclusions cycle free, i.e. the headers only have to depend on sys/_types.h.

{
(void)r;
(void)fd;
Expand All @@ -208,7 +208,7 @@ int _read_r(struct _reent *r, int fd, void *buffer, unsigned int count)
*
* @return TODO
*/
int _write_r(struct _reent *r, int fd, const void *data, unsigned int count)
_ssize_t _write_r(struct _reent *r, int fd, const void *data, size_t count)
{
(void) r;
(void) fd;
Expand Down