Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Support Markdown file type (closes #208) #215

Merged
merged 3 commits into from
Nov 3, 2019

Conversation

jwflory
Copy link
Member

@jwflory jwflory commented Nov 3, 2019

This PR makes a collection of changes to our docs. To highlight the commit message summaries:

A future PR might convert over our existing ReStructuredText docs to Markdown, for simplicity.

@jwflory jwflory added improvement Improves on something that already exists documentation Improvements or additions to documentation labels Nov 3, 2019
@jwflory jwflory requested a review from a team November 3, 2019 21:25
@jwflory jwflory self-assigned this Nov 3, 2019
Copy link
Member

@Tjzabel Tjzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Justin W. Flory <git@jwf.io>
This should be documented somewhere as part of the release process. I
didn't realize our docs were publishing for older versions.

Signed-off-by: Justin W. Flory <git@jwf.io>
This commit adds Markdown support to our documentation. Files that end
in a `.md` extension will be detected by Sphinx as documentation to
render in `docs/`. We can write in whatever format we wish.

Closes RITlug#208.

Signed-off-by: Justin W. Flory <git@jwf.io>
@jwflory jwflory merged commit 962abbc into RITlug:master Nov 3, 2019
@jwflory jwflory deleted the 208/docs-markdown-support branch November 3, 2019 23:38
jwflory added a commit to jwflory/teleirc that referenced this pull request Nov 4, 2019
This commit switches our Travis CI builds over to a matrix build system.
In addition to performing the standard unit test suite for NodeJS, it
will also kick up a VM to build and test our docs. This is a fairly
lightweight way to guarantee that our docs are building.

Also, you will notice this commit is failing! That is expected. The
`recommonmark` dependency was not added in RITlug#215, but it was added in
PR RITlug#217. Once that PR merges, this CI test will pass again.

Signed-off-by: Justin W. Flory <git@jwf.io>
jwflory added a commit to jwflory/teleirc that referenced this pull request Nov 4, 2019
This commit switches our Travis CI builds over to a matrix build system.
In addition to performing the standard unit test suite for NodeJS, it
will also kick up a VM to build and test our docs. This is a fairly
lightweight way to guarantee that our docs are building.

Also, you will notice this commit is failing! That is expected. The
`recommonmark` dependency was not added in RITlug#215, but it was added in
PR RITlug#217. Once that PR merges, this CI test will pass again.

Signed-off-by: Justin W. Flory <git@jwf.io>
jwflory added a commit that referenced this pull request Nov 4, 2019
This commit switches our Travis CI builds over to a matrix build system.
In addition to performing the standard unit test suite for NodeJS, it
will also kick up a VM to build and test our docs. This is a fairly
lightweight way to guarantee that our docs are building.

Also, you will notice this commit is failing! That is expected. The
`recommonmark` dependency was not added in #215, but it was added in
PR #217. Once that PR merges, this CI test will pass again.

Signed-off-by: Justin W. Flory <git@jwf.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improves on something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Markdown file type in documentations
2 participants