ci: Run go test, upload results to CodeClimate #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwflory
added
improvement
jwflory
force-pushed
the
change/run-tests
branch
from
bc2280f
to
74f83d9
Compare
|
Hmm, running into issues with CodeClimate. It's not uploading the test output. Give me some time next week to debug this. For now, this PR is not ready to merge yet. |
jwflory
added
needs changes
jwflory
force-pushed
the
change/run-tests
branch
from
65afc91
to
b1ff566
Compare
I also changed our test suite to test on Go 1.14.x instead of latest Go master, since I think it makes more sense to test on stable Go code than the latest changes. Even if Go `master` tests failed, to me, it wouldn't necessarily block a PR. Just tell us that something might be changing soon, eventually, someday™. Shout-out to @Zedjones for helping us figure this out in the developer meeting today. This also adds a snazzy test coverage badge to our README. This will render correctly once this PR builds on `master`. Signed-off-by: Justin W. Flory <git@jwf.io>
jwflory
force-pushed
the
change/run-tests
branch
from
d5d9e76
to
0e901a5
Compare
|
This is now working. It took a little bit of figuring out since the docs weren't fantastic. But I verified this did upload a test coverage report up to CodeClimate. Not sure if this is a public URL or not: This should start working and showing our total project test coverage once this builds and runs on |
|
Super! Let's see how this goes. Merging! 🎬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed our test suite to test on Go 1.14.x instead of latest Go
master, since I think it makes more sense to test on stable Go code than
the latest changes. Even if Go
mastertests failed, to me, it wouldn'tnecessarily block a PR. Just tell us that something might be changing
soon, eventually, someday™.
Shout-out to @Zedjones for helping us figure this out in the developer
meeting today.