Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: Cover more tools and editors #296

Merged
merged 1 commit into from
Apr 7, 2020
Merged

gitignore: Cover more tools and editors #296

merged 1 commit into from
Apr 7, 2020

Conversation

jwflory
Copy link
Member

@jwflory jwflory commented Apr 4, 2020

This commit greatly expands the coverage of the .gitignore file to the
following types of categories:

  • TeleIRC-specific files
  • Operating Systems (Linux, macOS, Windows)
  • Programming Languages (Go, Python)
  • Text Editors (Sublime Text, Vim, VSCode)

@jwflory
🌁 gitignore: Cover more tools and editors
907ade7 
This commit greatly expands the coverage of the `.gitignore` file to the
following types of categories:

* TeleIRC-specific files
* Operating Systems (Linux, macOS, Windows)
* Programming Languages (Go, Python)
* Text Editors (Sublime Text, Vim, VSCode)

Signed-off-by: Justin W. Flory <git@jwf.io>
@jwflory jwflory added improvement Improves on something that already exists contributor experience Quality-of-life improvements or changes to project contribution processes or resources labels Apr 4, 2020
@jwflory jwflory requested a review from a team April 4, 2020 20:00
@jwflory jwflory self-assigned this Apr 4, 2020
@jwflory jwflory added this to In progress in TeleIRC development via automation Apr 4, 2020
@jwflory
Copy link
Member Author

jwflory commented Apr 4, 2020

Also I dropped the Dockerfile ignore because based on today's dev meeting discussion, we will probably ship just one container image, not multiple like we did in v1.x.x.

Tjzabel
Tjzabel approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@Tjzabel Tjzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers quite a few programs, but sure, looks good.

I think moving to a single Dockerfile is a good idea.

@jwflory jwflory merged commit df147c6 into RITlug:master Apr 7, 2020
TeleIRC development automation moved this from In progress to Done Apr 7, 2020
@jwflory jwflory deleted the change/gitignore branch April 7, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tjzabel Tjzabel Tjzabel approved these changes

Assignees

@jwflory jwflory

Labels
contributor experience Quality-of-life improvements or changes to project contribution processes or resources improvement Improves on something that already exists
Projects
TeleIRC development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwflory @Tjzabel