-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imgur: Allow use with an account and album #402
Conversation
Thanks for the extensive documentation on this Pull Request @half-duplex. It's especially appreciated. I just changed a setting for the CircleCI pipeline where it should properly build Pull Requests submitted from a forked repository. If you push a new commit to this Pull Request, the CI builds should execute completely. |
2149920
to
f44b8e9
Compare
All tests passed except the Go 1.17 tests. This is because this test suite also uses a secret credential to upload the test coverage results to CodeClimate. The secret credential is only available on branches on this repository. So, all test suites are passing here. There is some feedback from CodeClimate about too many |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! Just had a few comments and spelling error.
Also not sure if there's a better way to format the returns in imgur.go
. For me I'm fine with the number of returns.
f44b8e9
to
b373cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Tjzabel or any @RITlug/teleirc-developers-commit-access member, want to take a final pass here?
I rebased this PR on the latest changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for making these changes 👍
I'd like to have the ability to collect and manage uploaded images. The easiest way to do this is to upload to an Imgur account instead of anonymously, and to an album.
As I said in the other PR, I don't really speak golang, so I appreciate comments.
Note: Imgur's documentation states that access tokens are valid for 1 month, but the ones the API returns seem to not expire for 10 years. If they ever change this, bots in this configuration running for over 1 month will need a restart to refresh the token.