Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build NOTE: use of unexported objects #100

Open
jacobvjk opened this issue Mar 4, 2024 · 2 comments
Open

Build NOTE: use of unexported objects #100

jacobvjk opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
maintenance keep the code running well migrated! question Further information is requested

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Mar 4, 2024

Unexported objects imported by ':::' calls:
    ‘r2dii.plot:::abort_if_missing_names’
    ‘r2dii.plot:::abort_if_unknown_values’
    See the note in ?`:::` about the use of this operator.

@jdhoffa @MonikaFu maybe we can either export these functions in r2dii.plot or put them elsewhere to avoid duplication and sketchy dependencies?

@jacobvjk jacobvjk added question Further information is requested maintenance keep the code running well labels Mar 4, 2024
@jacobvjk jacobvjk self-assigned this Mar 4, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Mar 4, 2024

These functions are pretty simple (i don't think they warrant a whole new package).
I would just write them out again in this package and maintain them here

@MonikaFu
Copy link
Collaborator

MonikaFu commented Mar 4, 2024

I agree with Jackson. Probably the best solution as they are not the core functionality of r2dii.plot but helper functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance keep the code running well migrated! question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants