Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-walrus pre-commit hook #126

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add auto-walrus pre-commit hook #126

merged 2 commits into from
Nov 23, 2023

Conversation

anayden
Copy link
Collaborator

@anayden anayden commented Nov 22, 2023

Hey @AntonPetrov I stumbled upon this pre-commit hook and immediately realized R2DT is in a dire need of it.

Copy link

github-actions bot commented Nov 22, 2023

Docker image tag(s) pushed:

rnacentral/r2dt:pr-126

Labels added to images:

org.opencontainers.image.created=2023-11-22T20:29:35.850Z
org.opencontainers.image.description=Visualise RNA secondary structure in consistent, reproducible and recognisable layouts
org.opencontainers.image.licenses=Apache-2.0
org.opencontainers.image.revision=a5e96b6c437ec611060b0f47f537a126d91959ec
org.opencontainers.image.source=https://github.com/RNAcentral/R2DT
org.opencontainers.image.title=R2DT
org.opencontainers.image.url=https://github.com/RNAcentral/R2DT
org.opencontainers.image.version=pr-126

@AntonPetrov
Copy link
Member

@anayden What a really useful contribution, thank you very much! 🦭🦭🦭

Just curious if it actually changes any existing code when you do pre-commit run auto-walrus? If it does, those changes should probably be made in the same PR (after all the tests pass of course).

@anayden
Copy link
Collaborator Author

anayden commented Nov 22, 2023

Just curious if it actually changes any existing code

No, it doesn't. The code is already 100% walrus'ed. But this is a nice-to-have hook for future contributions.
It just makes syntax more modern (and more walrus-ish), where applicable.

@AntonPetrov AntonPetrov merged commit 0d633c8 into develop Nov 23, 2023
3 checks passed
@AntonPetrov AntonPetrov deleted the auto-walrusize-r2dt branch November 23, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants