New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review #2

Open

kinnalru opened this issue Dec 17, 2020 · 0 comments

Member

kinnalru commented Dec 17, 2020 •

edited

Loading

использовать Tmpdir вместо rm_rf. rm_rf небезопасно - описался в конфиге и снес себе всю папку пользователя
dependencies: database_cleaner, rspec
тестов нет
после первичной эксплуатация я бы поискал повод уйти от процессов к внутренним повторам так, как это делает rspec-retry https://github.com/NoRedInk/rspec-retry/blob/master/lib/rspec/retry.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment