-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arduino: Compile sketches without warnings #85
Comments
Hi, @KurtE I totally agree with your opinion. So, I will try to find these warnings and remove them. Thank you for your contributions. |
@KurtE,
In the case of Dynamixel Workbench, this issue will be communicated to the team that manages the code and will be modified or not, depending on the team's decision. If you have other improvements, please leave issues. |
Thanks,
Hopefully Dynamixel Workbench will be updated as well, although I don’t typically use it except to maybe try out a thing or two.
I know with Teensy processors (PJRC), we were able to get Adafruit to take some Pull Requests to update some of their libraries in the past.
Who knows maybe at some point I will ty out some of them and see if they will take the updates… But maybe at some point I need to get
A second OpenCR board, to experiment on outside of the Turtlebot 3…
Again Thanks.
P.S – In some of these cases do you prefer Issues or for example the issue about platform.txt I could have setup to issue a Pull Request.
But not sure if you would prefer it based on Master or develop branch, I am guessing the later.
From: Kei <notifications@github.com>
Sent: Monday, April 30, 2018 1:02 AM
To: ROBOTIS-GIT/OpenCR <OpenCR@noreply.github.com>
Cc: KurtE <kurte@rockisland.com>; Mention <mention@noreply.github.com>
Subject: Re: [ROBOTIS-GIT/OpenCR] Arduino: Compile sketches without warnings (#85)
@KurtE <https://github.com/KurtE> ,
I have modified the code for All warning except for a few things below.
* MadgwickAHRS
* Adafruit's libraries
* Dynamixel Workbench
* FreeRTOS (cmsis_os, etc..)
In the case of Dynamixel Workbench, this issue will be communicated to the team that manages the code and will be modified or not, depending on the team's decision.
Other libraries are not modified because they use external libraries. (Exceptionally, the HAL library has been modified since it applies to all compilations)
If you have other improvements, please leave issues.
Thanks :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#85 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfGQLDuxyKvnBOVtKcYqemF9onmTrBpks5ttsUPgaJpZM4Toqcj> .
|
We are open source, so we welcome Pull Requests at any time.
It is as you guessed :). We want to develop. (We will add a contribute file in this regard) |
Sorry not sure if this is right place or if you are wanting issues raised like this.
I typically try to build my applications to be able to do builds without any compiler warnings as often times warnings turn out to be bugs I have not ran into yet...
So if you choose OpenCR as the board type, and turn on compile warnings:
File->Preferences (or CTRL-,)
And turn on options for Vebose output Compile, and compiler Warnings ALL,
And then try to build a program like the Example a_Serial_HelloWorld I am currently seeing lots of Warnings:
Note: I am running Arduino 1.8.5 and OpenCR 1.1.2... Windows 10 64bit
Output shown during Build:
The text was updated successfully, but these errors were encountered: