Fix precompiled libraries linkage on Arduino #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acuadros95
changed the title
|
@Acuadros95 |
This was referenced Jan 28, 2022
Merged
|
Thanks for the quick response @ROBOTIS-Will ! |
|
@pablogs9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes precompiled libraries linkage in OpenCR Arduino platform.
Purpose:
We are having problems with micro-ROS for arduino library link process
Our latest implementation includes packages with repeated symbols name and as our library is within the
--whole-archivelinker option, we end up with a lot of multiple definition link errors.This PR moves our library out to the
--no-whole-archivepart, letting the linker optimize this symbols out.Related: #253 (CC: @pablogs9)