Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][perl] Excessive dim3(...) constructor in kernel launch statement #246

Closed
emankov opened this issue Dec 18, 2020 · 1 comment
Closed

[HIPIFY][perl] Excessive dim3(...) constructor in kernel launch statement #246

emankov opened this issue Dec 18, 2020 · 1 comment
Assignees
@emankov
Labels
bug Something isn't working perl perl-related

Comments

@emankov
Copy link
Collaborator

emankov commented Dec 18, 2020

Occurs when dim3(...) already presented in CUDA kernel launch syntax.
For instance, in device_symbols.cu:

Assign<<<dim3(1, 1, 1), dim3(NUM, 1, 1)>>>(Ad);

should be converted by hipify-perl to:

hipLaunchKernelGGL(Assign, dim3(1, 1, 1), dim3(NUM, 1, 1), 0, 0, Ad);

The actual conversion result is:

hipLaunchKernelGGL(Assign, dim3(dim3(1, 1, 1)), dim3(dim3(NUM), 1, 1), Ad);
@emankov emankov added bug Something isn't working perl perl-related labels Dec 18, 2020
@emankov emankov self-assigned this Dec 18, 2020
emankov added a commit to emankov/HIPIFY that referenced this issue Feb 24, 2021
@emankov
[HIPIFY][ROCm#246] Fix kernel launching transformation in hipify-perl
b584082 
+ Fix generateKernelLaunch() for hipify-perl
+ Update hipify-perl accordingly
+ Add synthetic test kernel_launch_syntax.cu for both hipify-clang and hipify-perl
emankov added a commit that referenced this issue Feb 24, 2021
@emankov
Merge pull request #288 from emankov/HIPIFY
6a7af8f 
[HIPIFY][#246] Fix kernel launching transformation in hipify-perl
@emankov
Copy link
Collaborator Author

emankov commented Feb 24, 2021

Fixed with #288

@emankov emankov closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
bug Something isn't working perl perl-related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emankov