We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similar to #7 with the only difference that nested MACRO is an identifier, not a defined numeric literal.
Example:
checkCudaErrors(cublasSgemm(handle, CUBLAS_OP_N, CUBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
where both marked identifiers are MACRO: #define checkCudaErrors(val) check ( (val), #val, _FILE_, _LINE_ ) #define cublasSgemm cublasSgemm_v2
After hipifying now: checkCudaErrors(cublasSgemm(handle, HIPBLAS_OP_N, HIPBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
Should be: checkCudaErrors(hipblasSgemm(handle, HIPBLAS_OP_N, HIPBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
The text was updated successfully, but these errors were encountered:
Fixed. /gerritgit/compute/ec/hip (amd-develop branch): SHA-1: 2383d9bc
Sorry, something went wrong.
[HIPIFY] nested macro is not hipified, when it isAnyIdentifier
2383d9b
Fix for https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/55
e07148f
emankov
No branches or pull requests
Similar to #7 with the only difference that nested MACRO is an identifier, not a defined numeric literal.
Example:
checkCudaErrors(cublasSgemm(handle, CUBLAS_OP_N, CUBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
where both marked identifiers are MACRO:
#define checkCudaErrors(val) check ( (val), #val, _FILE_, _LINE_ )
#define cublasSgemm cublasSgemm_v2
After hipifying now:
checkCudaErrors(cublasSgemm(handle, HIPBLAS_OP_N, HIPBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
Should be:
checkCudaErrors(hipblasSgemm(handle, HIPBLAS_OP_N, HIPBLAS_OP_N, matrix_size.uiWB, matrix_size.uiHA, matrix_size.uiWA, &alpha, d_B, matrix_size.uiWB, d_A, matrix_size.uiWA, &beta, d_C, matrix_size.uiWB));
The text was updated successfully, but these errors were encountered: