Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long workload name layout fix #269

Merged
merged 15 commits into from
Apr 3, 2023

Commits on Apr 2, 2023

  1. Omnitrace causal viewer initial implementation (ROCm#242)

    * initial gui commit with workloads folder
    
    * Insert Workload directory, and Drag/drop works, options/values update correctly
    
    * min points is now a slider and updates on each workload. still doesnt filter
    
    * min points filter, now filters
    
    * points filter works with point selection
    
    * globs workloads in current dir and one level down
    
    * regex filters
    
    * regex filtering works
    
    * changed index tuples in dataframes
    
    * added correct indexing to data
    
    * Remove pycache files
    
    * ignore .pyc files
    
    * format python files
    
    * deleted unnecessary workload files
    
    * remove unused python scripts
    
    * add requirements.txt
    
    * remove unused imports + unnecessary code
    
    * Relocated source files
    
    * support pip installation
    
    * changed layout to handle more data, updated to new json format
    
    * return of smooth lines
    
    * scrollable histogram
    
    * fixed for throughput
    
    * formatting
    
    * miscellaneous fixes
    
    * precalc sorting values for less work in callback
    
    - added compute_sorts to precalculate dataframe sort columns
    -renamed columns in compute_speedups to same format as output
    -removed sorting algorithms from callback
    -fixed func_regex and exp_regex to use func_list and exp_list
    
    * Min/Max sort works
    
    -min/max sort fixed,
    -For some reason dataframe is calculated twice...
    
    * Merge with new compute scripts
    
    -create settings if nonexistent
    -write current path, and clil flag to settings after argparse
    -add new flags from validation script
    -use impact avg from validation scripts
    -use new classes for calculating throughput/latency/impact
    -uses regex from cli for progress points/experiments
    
    * Remove outdated code
    
    -removed unused/commented code
    -fixed import errors
    
    * reformatting
    
    * Pasting path in gui fix
    
    -fixed parser default values
    -pasting path to workload folder in box fixed to new format
    
    * drag and drop file fix
    
    * Updated python headers + v0.1.0 + fixed --version
    
    - set version to 0.1.0
    - moved source/python/gui/VERSION to source/python/gui/source/VERSION
    - populated __init__.py with __version__
    - populated all python files with author, copyright, license, maintainer, and status
    - fixed usage from installation
    
    * formatting
    
    ---------
    
    Co-authored-by: JoseSantosAMD <Josantos@amd.com>
    jrmadsen and JoseSantosAMD committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    c14b555 View commit details
    Browse the repository at this point in the history
  2. Call stack sample histogram (ROCm#246)

    * Update workflow paths-ignore
    
    * Fix call-stack histogram + reorder display
    
    - read in call-stack samples and generate bar graph
    - reorder display so that call-stack histogram is at bottom
    jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    88243e8 View commit details
    Browse the repository at this point in the history
  3. Refresh button (ROCm#247)

    * refresh button
    
    - globally saves workload path given from main
    - add refresh button
    - re runs parsefile with workload path
    
    * refresh button works with insert path
    
    - refreshes data in workload path
    - accepts both directory and file
    - if directory only stores first file found for now
    - some renaming
    
    * formatting
    
    ---------
    
    Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
    jrmadsen and JoseSantosAMD committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6b4d422 View commit details
    Browse the repository at this point in the history
  4. Causal profiling GUI: error bars (ROCm#248)

    * Added error bars
    
    - from impact stddev
    
    * formatting
    
    - NOTE: a future PR will resolve this PR using the incorrect data for the error bars
    
    ---------
    
    Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
    jrmadsen and JoseSantosAMD committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6ce464a View commit details
    Browse the repository at this point in the history
  5. Causal profiling GUI: support startup w/o workload (ROCm#249)

    * Gui can be started with no workload.
    
    - some renaming of functions
    - if empty data, empty div is returned
    
    * workloads can be directory also
    
    * filtering errors fix
    
    - fix errors from applying sort/filters when data is empty
    
    ---------
    
    Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
    jrmadsen and JoseSantosAMD committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    c84c85a View commit details
    Browse the repository at this point in the history
  6. Multiple files now read from directory (ROCm#253)

    * Multiple files now read from directory
    
    -Now accepts multiple jsons in directory
    -samples error fix
    -light mode now an option
    -select which file to present data from dropdown
    (Does not work with histogram yet)
    -workload added to dataframe
    -More color options
    
    * Reformat
    
    * Requested Changes
    
    -Uses os.path.basename
    -removed data for runs_dict
    -default is now sorted by impact
    -naming convention consistency fix
    -No more filt_kernel_names
    -gui console output determined by verbosity
    
    * terminal output if verbosity > 3 or only CLI
    
    * Use Imapct sum instead of avg
    
    -verbosity help menu update
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    4119ef7 View commit details
    Browse the repository at this point in the history
  7. Verbose mode (ROCm#260)

    * Multiple files now read from directory
    
    -Now accepts multiple jsons in directory
    -samples error fix
    -light mode now an option
    -select which file to present data from dropdown
    (Does not work with histogram yet)
    -workload added to dataframe
    -More color options
    
    * Reformat
    
    * terminal output if verbosity > 3 or only CLI
    
    * Terminal Verbosity can now change from gui
    
    -Drop down selects verbose level
    -1: Shows input from gui on terminal
    -2: shows points in data
    -3: Used for debugging
    
    -Also fixed path vs directory bug in input path from gui
    
    * multiple verbose modes in terminal set by gui
    
    -multi selection in sort by is removed, kept in workloads
    -verbose mode 2 shows data from print_speedup_info
    -sort by changed to if/elif
    -removed unused fig
    -fixed errorbars
    -line_stddev now in dataframe
    
    * Reformatting gui labels and filters
    
    - resizing filters
    - renamed labels in graphs for consistency
    - renamed labels in dataframe for consistency
    - moved styling to styling sheets
    
    * Formatting
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    f84333f View commit details
    Browse the repository at this point in the history
  8. Fix Causal GUI PR ROCm#260 (ROCm#262)

    * Fixes for PR ROCm#260
    
    - Remove duplicate -l / --light argument
    - Add missing "multi" dict entries for input filters
    
    * Update RedHat workflow
    
    - ignore changes to source/python/gui/**
    
    * Fixed sizing for drop downs
    
    ---------
    
    Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
    jrmadsen and JoseSantosAMD committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    2a2110e View commit details
    Browse the repository at this point in the history
  9. Miscellaneous Causal GUI Fixes (ROCm#264)

    * Fully remove verbosity tab
    
    * parser, gui, main updates
    
    - parser.parse_files returns filenames
    - parser.parse_files handles verbosity
    - parser.parse_files handles settings
    - gui fixes removing verbosity
    - improved main
      - call parse_files
      - support recursive glob
      - improved settings support
      - support ~/.omnitrace-causal-plot.json
    jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    16b1233 View commit details
    Browse the repository at this point in the history
  10. changed layout to fit experiment names

    - added span to show full name
    - shortened name to fit dropwdown
    - changed layout for added consistency
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    08110f6 View commit details
    Browse the repository at this point in the history
  11. layout Fixes

    - refresh button is to the right
    - header is more consistent across different width screens
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d70d254 View commit details
    Browse the repository at this point in the history
  12. header layout update

    - center div makes turns into multiple lines if not all items fit
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    e3efe09 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a91a5e8 View commit details
    Browse the repository at this point in the history
  14. Fixed refresh button shape and function

    - moved find_causal_files to parser so that main and gui can access
    - resized refresh width to allow for same shape across different screens
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    26ddb7d View commit details
    Browse the repository at this point in the history
  15. all graphs now have the same width

    - graphs now have same width
    
    - chart headers start well below the header with filters
    JoseSantosAMD authored and jrmadsen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    37dcfa0 View commit details
    Browse the repository at this point in the history