Causal profiling GUI: error bars #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-from impact stddev
jrmadsen
added a commit
that referenced
this pull request
Mar 21, 2023
* Added error bars - from impact stddev * formatting - NOTE: a future PR will resolve this PR using the incorrect data for the error bars --------- Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
jrmadsen
added a commit
that referenced
this pull request
Mar 22, 2023
* Added error bars - from impact stddev * formatting - NOTE: a future PR will resolve this PR using the incorrect data for the error bars --------- Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
jrmadsen
added a commit
to JoseSantosAMD/omnitrace
that referenced
this pull request
Apr 3, 2023
* Added error bars - from impact stddev * formatting - NOTE: a future PR will resolve this PR using the incorrect data for the error bars --------- Co-authored-by: JoseSantosAMD <Jose.Santos@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to merge this but it is using the wrong standard deviation data. The error bars should reflect the experiment progress point standard deviation at a specific virtual speedup, not the impact standard deviation. In other words, the error bar should show how much variance is in the virtual speedup prediction.