Multiple files now read from directory #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Now accepts multiple jsons in directory -samples error fix -light mode now an option -select which file to present data from dropdown (Does not work with histogram yet) -workload added to dataframe -More color options
|
@JoseSantosAMD you need to format the code |
jrmadsen
requested changes
Mar 7, 2023
-Uses os.path.basename -removed data for runs_dict -default is now sorted by impact -naming convention consistency fix -No more filt_kernel_names -gui console output determined by verbosity
jrmadsen
reviewed
Mar 7, 2023
-verbosity help menu update
jrmadsen
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Multiple files now read from directory -Now accepts multiple jsons in directory -samples error fix -light mode now an option -select which file to present data from dropdown (Does not work with histogram yet) -workload added to dataframe -More color options * Reformat * Requested Changes -Uses os.path.basename -removed data for runs_dict -default is now sorted by impact -naming convention consistency fix -No more filt_kernel_names -gui console output determined by verbosity * terminal output if verbosity > 3 or only CLI * Use Imapct sum instead of avg -verbosity help menu update
jrmadsen
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Multiple files now read from directory -Now accepts multiple jsons in directory -samples error fix -light mode now an option -select which file to present data from dropdown (Does not work with histogram yet) -workload added to dataframe -More color options * Reformat * Requested Changes -Uses os.path.basename -removed data for runs_dict -default is now sorted by impact -naming convention consistency fix -No more filt_kernel_names -gui console output determined by verbosity * terminal output if verbosity > 3 or only CLI * Use Imapct sum instead of avg -verbosity help menu update
jrmadsen
pushed a commit
to JoseSantosAMD/omnitrace
that referenced
this pull request
Apr 3, 2023
* Multiple files now read from directory -Now accepts multiple jsons in directory -samples error fix -light mode now an option -select which file to present data from dropdown (Does not work with histogram yet) -workload added to dataframe -More color options * Reformat * Requested Changes -Uses os.path.basename -removed data for runs_dict -default is now sorted by impact -naming convention consistency fix -No more filt_kernel_names -gui console output determined by verbosity * terminal output if verbosity > 3 or only CLI * Use Imapct sum instead of avg -verbosity help menu update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Now accepts multiple jsons in directory
-samples error fix
-light mode now an option
-select which file to present data from dropdown
(Does not work with histogram yet)
-workload added to dataframe
-More color options