Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slice variable inputs update #2349

Closed
CharlieL7 opened this issue Oct 20, 2023 · 1 comment · Fixed by #2394 or #2445
Closed

slice variable inputs update #2349

CharlieL7 opened this issue Oct 20, 2023 · 1 comment · Fixed by #2394 or #2445
Assignees
@CharlieL7

Comments

@CharlieL7
Copy link
Collaborator

MIGraphX's slice operator needs to handle calls like these:
slice(data, input_ends)
slice(data, input_starts)
slice(data, input_starts, input_axes)
Because constant inputs to slice will be set in the attribute while variable inputs are supplied as arguments.
@CharlieL7 CharlieL7 self-assigned this Oct 20, 2023
@CharlieL7
Copy link
Collaborator Author

Need to also update simplfy_dyn_ops for this

@attila-dusnoki-htec attila-dusnoki-htec mentioned this issue Nov 9, 2023
Open
This was linked to pull requests Nov 30, 2023
Handle all slice input variations #2394
Merged
Simplify constant variable input slices #2445
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlieL7 CharlieL7

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@CharlieL7