Updating rocm_configure.bzl to account for ROCm 5.2 related header file changes (rccl)
#1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file changes (rccl) ROCM 5.2 mainline build 9933 introduces changes to the location of the rccl header/libary files, which lead to the following TF build failure. This commit updates the `rocm_configure.bzl` file to fix that build failure. ``` ERROR: Traceback (most recent call last): File "/root/.cache/bazel/_bazel_root/efb88f6336d9c4a18216fb94287b8d97/external/local_config_rocm/rocm/BUILD", line 1730, column 8, in <toplevel> genrule( Error in genrule: generated file 'rocm/include/rccl/rccl.h' in rule 'rccl-include' conflicts with existing generated file from rule 'rocm-include', defined at /root/.cache/bazel/_bazel_root/efb88f6336d9c4a18216fb94287b8d97/external/local_config_rocm/rocm/BUILD:185:8 INFO: Repository rules_proto instantiated at: /root/tensorflow/WORKSPACE:23:14: in <toplevel> /root/tensorflow/tensorflow/workspace0.bzl:116:17: in workspace Repository rule http_archive defined at: /root/.cache/bazel/_bazel_root/efb88f6336d9c4a18216fb94287b8d97/external/bazel_tools/tools/build_defs/repo/http.bzl:364:31: in <toplevel> ERROR: /root/tensorflow/tensorflow/stream_executor/rocm/BUILD:426:11: errors encountered resolving select() keys for //tensorflow/stream_executor/rocm:all_runtime ERROR: Analysis of target '//tensorflow/stream_executor/rocm:all_runtime' failed; build aborted: ```
|
jenkins : retest Ubuntu-GPU-multi please |
|
replaced by: #1668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is really a continuation for PRs #1603, #1605, #1607, #1612, #1614, #1617, #1620 and #1628 (in the ROCm TF fork)
ROCM 5.2 mainline build 9933 introduces changes to the location of the rccl header/libary files, which lead to the following TF build failure.
This commit updates the
rocm_configure.bzlfile to fix that build failure.