Skip to content

a-tisket seeder for Apple Music sometimes fails with status 429 #438

@kellnerd

Description

@kellnerd

https://community.metabrainz.org/t/ropdebees-userscripts-support-thread/551947/57

On a rare occasion I saw a 429 from Apple. This caused the link for cover art seeding not to be added. Perhaps the script could gracefully retry or show a manual retry option?
https://atisket.pulsewidth.org.uk/?spf_id=1WRqanANwPz8JyH0p78IPh

9999x9999-100.jpg:1          Failed to load resource: the server responded with a status of 429 ()
MB: Enhanced Cover Art Uploads.user.js:105074 [mb_enhanced_cover_art_uploads] Failed to add seed links to some cover art
onError @ MB: Enhanced Cover Art Uploads.user.js:105074

const imageDimensions = await getImageDimensions(imageUrl);

Has to be related to the fetching of the image's dimensions since the insertion of the seed link itself should not cause an additional request to Apple's servers. The HTTP error makes the whole function fail, maybe these two features should be separated to avoid this.
Probably not worth to fix the underlying issue right now, automatic retries could be part of the refactoring of mb_caa_dimensions into TS modules instead.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions