Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: F1 2012 [BLUS31014] Not Booting (#4975) #4999

Closed
TotalCaesar659 opened this issue Aug 18, 2018 · 9 comments · Fixed by #5022
Closed

Regression: F1 2012 [BLUS31014] Not Booting (#4975) #4999

TotalCaesar659 opened this issue Aug 18, 2018 · 9 comments · Fixed by #5022

Comments

@TotalCaesar659
Copy link
Contributor

In #4973, F1 2012 has white screen only and many warnings

·E 0:00:35.316872 {rsx::thread} RSX: Invalid FIFO queue get/put registers found, get=0x1000, put=0x94A4
·E 0:00:35.316875 {rsx::thread} RSX: Application has failed to recover, resetting FIFO queue

that cause memory leak.
F1_2012.zip

@kd-11
Copy link
Contributor

kd-11 commented Aug 18, 2018

If this is a race condition introduced by the speed boost in that PR, then it is a duplicate of #2359. If not, could be introduced by the previous commits changing memory addressing. The AAA fixes PR by itself does not modify vm memory behaviour in any way.
To determine if its a race condition, check if the issue is always present for everyone. You will likely find someone who can get ingame. Also check if HLE gcm fixes the problem (select manual load library and load the necessary libraries only (spurs_jq, sre, resc, rtc)

@TotalCaesar659
Copy link
Contributor Author

TotalCaesar659 commented Aug 18, 2018

check if the issue is always present for everyone

I don't understand, do you want me to test previous builds before AAA fixes?

check if HLE gcm fixes the problem

OK, I'll do it now.

@MSuih
Copy link
Member

MSuih commented Aug 18, 2018

I don't understand, do you want me to test previous builds before AAA fixes?

No, he wants you to find someone else who owns that game and check if they can't get ingame either. If it's a race condition then some hardware combinations can probably get it ingame.

But since you are already blaming #4973 for the regression then you're implying that it worked before that PR. If you haven't tested any other builds then you should do that before accusing KD's changes for the regression.

@TotalCaesar659
Copy link
Contributor Author

TotalCaesar659 commented Aug 18, 2018

No, he wants you to find someone else who owns that game and check if they can't get ingame either. If it's a race condition then some hardware combinations can probably get it ingame.

Ah, I got this. Then maybe somebody else will see this thread and test it.

If you haven't tested any other builds then you should do that before accusing KD's changes for the regression.

If I blame some PR for bug, then it hadn't exist before this PR. I've tested this game on almost every PR, and it worked. So If you think that I don't have enough for this, you're mistaking.

check if HLE gcm fixes the problem (select manual load library and load the necessary libraries only (spurs_jq, sre, resc, rtc)

Done, it works with these settings.
f1_2012
F1_2012.zip

@MSuih
Copy link
Member

MSuih commented Aug 18, 2018

Oh, it was just a misunderstanding then. I apologize for the tone of my message.

@kd-11
Copy link
Contributor

kd-11 commented Aug 18, 2018

If HLE gcm fixes it then it suffers from the same gcm bug as skate3, which again, is not something that the PR touches. There were several vm memory patches committed into master in the last few days, check if it can be narrowed down to one of them. If not then its likely a race condition of some kind.

@TotalCaesar659
Copy link
Contributor Author

Finally, I've found the commit: the game works with #4953 and doesn't do with #4975.
F1_2012.zip

@AniLeo
Copy link
Member

AniLeo commented Aug 19, 2018

Retest with latest master, #5002 could have fixed this

@AniLeo AniLeo changed the title F1 2012 [BLUS31014]: white screen only Regression: F1 2012 [BLUS31014] Not Booting (#4975) Aug 19, 2018
@TotalCaesar659
Copy link
Contributor Author

Unfortunately, same result in #5010.
F1_2012.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants