Minor vm additions #5002
Merged
Minor vm additions #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent unmapping predefined locations
Add upgrade() method
elad335
reviewed
Aug 18, 2018
| @@ -844,15 +858,13 @@ namespace vm | |||
| { | |||
| if (location == vm::user64k || location == vm::user1m) | |||
| { | |||
| g_mutex.lock_upgrade(); | |||
| lock.upgrade(); | |||
|
|
|||
| if (!loc) | |||
| { | |||
| // Deferred allocation | |||
| loc = _find_map(0x10000000, 0x10000000, location == vm::user64k ? 0x201 : 0x401); | |||
There was a problem hiding this comment.
needs to remove this ternary op
There was a problem hiding this comment.
and change base on _find_map back to 0x30.. (github doesnt let me comment on that line).
There was a problem hiding this comment.
Removing them won't change anything...
There was a problem hiding this comment.
Both vm::user locs are "weak" - their exact address is either dynamic or undocumented, but that's enough to classify them differently. Other areas are hardcoded really hard. And _find_map only needs to start at the end of vm::main. Inbetween lies "uncertain" area which can be adjusted from the outside. That's how I see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.