Skylander - Change portal version #10061
Conversation
Switch emulation to the Traptanium portal. This portal is universal and works with all games.
rpcs3/Emu/Io/Skylander.cpp
Outdated
| @@ -272,7 +272,13 @@ void usb_device_skylander::control_transfer(u8 bmRequestType, u8 bRequest, u16 w | |||
| // Shutdowns the portal | |||
| ensure(buf_size == 2 || buf_size == 32); | |||
| q_result = { | |||
| 0x52, 0x02, 0x0A, 0x03, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; | |||
| 0x53, 0x00, 0x00, 0x00, 0x00, 0xc4, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; | |||
There was a problem hiding this comment.
0x53 packets are sent when there is a query but no pending data to get status of figures. Also you're using static values for the packet number which is definitely incorrect, see
rpcs3/rpcs3/Emu/Io/Skylander.cpp
Line 74 in 769c7bf
There was a problem hiding this comment.
Thanks for pointing that out. Initially it appeared the status packets were required but after further testing it appears it was just a timing issue reading the portal. The only real change needed is the version info in byte 2/3 from 0A03 to 1800.
That being said, there's a few additional query types I'm tracking down to see if they require any real response. It doesn't appear so but I'd rather be sure.
I'll update the PR tonight once I find those.
There was a problem hiding this comment.
please tell me where I need to put that code if u can please beacuse my traps arent working in game when I use the emulator portal
- Remove "Status" query responses from reset request - Add additional request types for newer portal
|
so i don't really know how programming or github works, but is there some time i can expect this to be fixed, or is it already fixed?? |
|
So where do I place this new code? |
|
Please help where I am going to put that code if someone knows please help me because my traps arent working correctly in skylanders trap team @RipleyTom @Desterly |
|
Posting messages on a closed PR isn't going to do anything, go to the Discord server if you want help |
|
OK can you sent a link to the discord server @YuriNator557 |
|
hey is this fixed yet? |
is this fixed?? can i play trap team now without my portal refrasching ? |
|
This PR has been merged and acheives the results that it was set out to acheive. |
|
OK thanks
…On Thu, Oct 27, 2022 at 2:27 AM Darkhost1999 ***@***.***> wrote:
This PR has been merged and acheives the results that it was set out to
acheive.
You can load traps.
This PR does not fix any exisiting issues discovered from enabling the
ability to use traps.
The issue you are discussing may have been exposed by this PR but
shouldn't be caused by it. And supposedly has not been fixed yet to answer
your question
All this PR does is enable the built into rpcs3 portal to be used in all
skylanders games and it was successful.
—
Reply to this email directly, view it on GitHub
<#10061 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZPP3DW5INJT4EG2OIFIIDDWFG44HANCNFSM42JS7M3A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Switch emulation to the Traptanium portal. This portal is universal
and works with all games.
Reset response updated to send portal version information.