Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: add fullscreen mouse lock setting #10629

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

ibancel
Copy link
Contributor

@ibancel ibancel commented Jul 29, 2021

Add a mouse lock setting in order to control the lock state when entering in fullscreen mode.
It can be useful when having multiple monitors.

rpcs3/rpcs3qt/gs_frame.h Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.ui Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
@Megamouse Megamouse added the GUI label Jul 29, 2021
@Megamouse
Copy link
Contributor

I don't know if this setting is actually necessary.
You can already set and release the lock with Ctrl+L

It would only serve as a pure setting that does not default to locked when entering fullscreen.
Unless that is what you wanted.

@ibancel
Copy link
Contributor Author

ibancel commented Jul 29, 2021

I don't know if this setting is actually necessary.
You can already set and release the lock with Ctrl+L

It would only serve as a pure setting that does not default to locked when entering fullscreen.
Unless that is what you wanted.

Yes it is only for defaulting when entering in fullscreen. This is bothering to do Ctrl+L each time and the shortcut is not obvious for newcomers in my opinion.

@Megamouse
Copy link
Contributor

Megamouse commented Jul 29, 2021

I could imagine that the more annoying part might be that - once you escaped it - you again get trapped as soon as you enter the game's monitor with your mouse.

@Megamouse
Copy link
Contributor

I searched for possible loopholes with the lock state but the code seems sound to me 👍
We'll now once someone complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants