Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTERS NEEDED] cellVdec overhaul -> fixes broken videos in Uncharted 2 #11754

Merged
merged 14 commits into from Apr 21, 2022
Merged

[TESTERS NEEDED] cellVdec overhaul -> fixes broken videos in Uncharted 2 #11754

merged 14 commits into from Apr 21, 2022

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 10, 2022 •
edited

  • Implemented a missing error CELL_VDEC_ERROR_SEQ in cellVdec.
    The error is returned whenever a function is called during the wrong state of the sequence decode.
    This could have an impact on all games and might break some (hopefully none) while fixing others.
  • Fixed the output line offsets for YUV formats (which fixes video output issues in Uncharted 2)
  • Added lots of error handling that was missing before. This might or might not impact some games.
  • Added a bunch of other random stuff that's probably not gonna change anything

Apparently also fixes #4167
Also seems to fix #8394

@Megamouse Megamouse changed the title cellVdec: implement CELL_VDEC_ERROR_SEQ [TESTERS NEEDED] cellVdec: implement CELL_VDEC_ERROR_SEQ Apr 10, 2022
@Megamouse Megamouse force-pushed the asdasdasd branch 3 times, most recently from 62b7ed4 to 3b508fa Compare April 10, 2022 10:49
@Asinin3
Copy link
Contributor

Asinin3 commented Apr 10, 2022

This PR causes video and audio to not output anything at all when libvdec,sprx is disabled (in Uncharted 2 at least). In master, with Uncharted 2 and libvdec.sprx is disabled video and audio still play, but the video has graphical issues.
image
To be clear, if libvdec.sprx is enabled it works just like it does in master.

@Megamouse Megamouse force-pushed the asdasdasd branch 10 times, most recently from e56dc08 to 19131cc Compare April 12, 2022 22:20
@Megamouse
Copy link
Contributor Author

@Asinin3 fixed Uncharted 2 Demo
image

@Megamouse Megamouse changed the title [TESTERS NEEDED] cellVdec: implement CELL_VDEC_ERROR_SEQ [TESTERS NEEDED] cellVdec overhaul -> fixes broken videos in Uncharted 2 Apr 12, 2022
This was referenced Apr 12, 2022
Open
Closed
Open
This was referenced Apr 13, 2022
Open
Closed
@Jonathan44062 Jonathan44062 mentioned this pull request Apr 13, 2022
Closed
@Megamouse Megamouse force-pushed the asdasdasd branch 3 times, most recently from 392fb3a to e88255f Compare April 13, 2022 20:03
@nitroos-ai nitroos-ai mentioned this pull request Apr 13, 2022
Closed
@Asinin3
Copy link
Contributor

Asinin3 commented Apr 14, 2022

Thanks for fixing Uncharted 2. I also tested Space Ace, a game which required libvdec.sprx to get to the title screen (due to intro video infinitely looping otherwise) behaves the same as master builds. Log if you want to look: RPCS3.log.gz

@Megamouse
Copy link
Contributor Author

Anyone review?

@Megamouse Megamouse merged commit f42e647 into RPCS3:master Apr 21, 2022
@Megamouse Megamouse deleted the asdasdasd branch April 21, 2022 20:24
@Devilke1233 Devilke1233 mentioned this pull request Apr 22, 2022
Closed
@illusion0001 illusion0001 mentioned this pull request Apr 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Firmware: HLE Video
Projects
None yet
Milestone
No milestone
2 participants
@Megamouse @Asinin3