PPU LLVM: Precompile system-internal executables if booting a dev_flash's program #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
fw-compile
branch
2 times, most recently
from
91b3e9e
to
e925497
Compare
Vestrel
reviewed
May 12, 2022
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| } | ||
| } | ||
|
|
||
| const std::string firmware_sprx_path = is_vsh ? "/dev_flash"sv : dev_flash_located ? "/dev_flash/sys"sv : "/dev_flash/sys/external"sv); |
There was a problem hiding this comment.
I don't think vsh specific check is needed.
elad335
force-pushed
the
fw-compile
branch
2 times, most recently
from
ffdcf89
to
e44b3b0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11979